Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events should not be deleteable after their start date #345

Open
2 tasks
MarcelSchmidberger opened this issue Jan 15, 2018 · 3 comments
Open
2 tasks

events should not be deleteable after their start date #345

MarcelSchmidberger opened this issue Jan 15, 2018 · 3 comments
Assignees
@usame-algan
Labels
epic create event in progress priority medium team bruteforce
Milestone
Sprint 4

Comments

@MarcelSchmidberger
Copy link
Contributor

MarcelSchmidberger commented Jan 15, 2018 •
edited
Loading

It should not be possible to delete an event after it started, because otherwise progress will be lost.
After its start an event should only be finished (#233) and archived.

Acceptance Criteria

  • an event can only be deleted until the event started
  • the admin can delete it any time
@MarcelSchmidberger MarcelSchmidberger added this to the Sprint 4 milestone Jan 15, 2018
@MarcelSchmidberger
Copy link
Contributor Author

@Askir Wouldnt this be easy to add to the state machine as well?

usame-algan pushed a commit that referenced this issue Jan 19, 2018
events cant be deleted after they started. Ref:#345
d5aaa8c
@MarcelSchmidberger
Copy link
Contributor Author

@usame-algan did you communicate with @Askir concerning the state machine integration for the event model?

@Askir
Copy link
Contributor

Askir commented Jan 19, 2018

It's fine to implement this separately for now. Once I merge the state machine we can reuse most of Usames code in this case. @MarcelSchmidberger

usame-algan pushed a commit that referenced this issue Jan 22, 2018
changes user ability to delete events. Ref:#345
fad5338
usame-algan pushed a commit that referenced this issue Jan 28, 2018
tests one of the given cucumber scenarios. Ref:#345
36b0cd8
usame-algan pushed a commit that referenced this issue Jan 30, 2018
adds more cucumber testcode. Ref:#345
d3c2a78
@usame-algan usame-algan mentioned this issue Jan 30, 2018
Closed
usame-algan pushed a commit that referenced this issue Jan 30, 2018
changes cucumber testcode. Ref:#345
b795cf5
usame-algan pushed a commit that referenced this issue Feb 1, 2018
changes cucumber test wording. Ref:#345
4587285
usame-algan pushed a commit that referenced this issue Feb 4, 2018
adds more cucumber testcode. Ref:#345
4d7560f
usame-algan pushed a commit that referenced this issue Feb 4, 2018
changes cucumber testcode. Ref:#345
4ea2027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@usame-algan usame-algan

Labels
epic create event in progress priority medium team bruteforce
Projects
None yet
Milestone
Sprint 4
Development

Successfully merging a pull request may close this issue.

345/bruteforce/event not deleteable after start hpi-swt2/sport-portal
3 participants
@usame-algan @Askir @MarcelSchmidberger