Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD Testing: compiling 3rd party software on Github #34

Open
varisd opened this issue Jul 31, 2024 · 0 comments
Open

CI/CD Testing: compiling 3rd party software on Github #34

varisd opened this issue Jul 31, 2024 · 0 comments
Assignees
Labels
help wanted Extra attention is needed question Further information is requested unit_tests

Comments

@varisd
Copy link
Contributor

varisd commented Jul 31, 2024

We need to add logic for preparing 3rd party dependencies (Marian NMT, OpusCleaner Python virtualenv, etc) on github for automated testing.
I am proposing following:

  • each dependency will be prepared in a fixed-name directory,
  • in tests/conftest.py, we will have session-scope fixtures for each dependency which will check whether the software is present/available (otherwise it will skip the fixture and the dependent tests) and return their respective directories (usable in subsequent tests)

Or do we have a better solution for these scenarios?

@varisd varisd added help wanted Extra attention is needed question Further information is requested unit_tests labels Jul 31, 2024
@varisd varisd added this to the MVP - August 31, 2024 milestone Jul 31, 2024
@rggdmonk rggdmonk self-assigned this Aug 26, 2024
@rggdmonk rggdmonk removed this from the MVP - August 31, 2024 milestone Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested unit_tests
Projects
None yet
Development

No branches or pull requests

2 participants