Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The raw step of the pipeline includes each corpus twice in the categories.json file #8

Closed
bhaddow opened this issue Feb 13, 2024 · 3 comments
Labels
bug Something isn't working need investigation Unknown scope

Comments

@bhaddow
Copy link
Contributor

bhaddow commented Feb 13, 2024

We are seeing that the generated script for the raw file includes each dataset twice. For example, see /pfs/lustrep3/scratch/project_465000574/malikbha/experiments/en-hr/simple/v0/s.raw.en-hr/step.command

The dataset is included only once in the original categories.json. However as far as I can see, when the pipeline generates the raw step, it does not see the original categories.json, but generates its own. This records each file twice, because of faulty logic in

@bhaddow
Copy link
Contributor Author

bhaddow commented Feb 13, 2024

The reason that the categories.json was being ignored is that @bhavitvyamalik temporarily by-passed it. But still, the pipeline should not generate two entries in this case.

@bhavitvyamalik
Copy link

I have fixed that in my new commit. I have pushed changes to lumi-tmp branch since @varisd's latest changes weren't working for me. It was more of a hack for time being, but now we can fix this problem i.e., to skip processing empty datasets (#12)

@rggdmonk rggdmonk added bug Something isn't working need investigation Unknown scope labels Jul 10, 2024
@rggdmonk
Copy link
Contributor

Resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need investigation Unknown scope
Projects
None yet
Development

No branches or pull requests

3 participants