New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria label to sort button #55

Open

drewbrew opened this issue Jan 10, 2020 · 0 comments

Labels

Collaborator

drewbrew commented Jan 10, 2020

More from the same guy as #52:

Similar to the hamburger menu, the sort button probably needs an aria-label="Sort List of Beers" and some sort of event listeners to activate via enter/spacebar. I'd also consider capturing spacebar on the navigation menu, but that all just kind of depends on implementation details

drewbrew added the accessibility label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment