Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use better booleans for the proxy control variables #68

Open
matyasselmeci opened this issue May 17, 2023 · 0 comments
Open

Use better booleans for the proxy control variables #68

matyasselmeci opened this issue May 17, 2023 · 0 comments

Comments

@matyasselmeci
Copy link
Collaborator

matyasselmeci commented May 17, 2023

Just looking at whether *_DISABLE_HTTP_PROXY and *_DISABLE_PROXY_FALLBACK are set or unset is a pain to deal with, since it's sometimes hard to actually unset an environment variable (for example, in the docker command line).

IsProxyEnabled() and CanDisableProxy() should parse those environment variables as booleans using strconv.ParseBool(). Treat an invalid boolean (i.e. ParseBool returning an error) as false.

Update README.md to say that OSG_DISABLE_PROXY_FALLBACK must be set to true to be enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant