Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dws): add datasource to query workload plans #5381

Merged
merged 1 commit into from
Aug 15, 2024
Merged

feat(dws): add datasource to query workload plans #5381

merged 1 commit into from
Aug 15, 2024

Conversation

wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

Add new datasource to query list of the workload plans under specified DWS cluster.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new datasource huaweicloud_dws_workload_plans.
2. add related document and acceptance test.

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
 make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccDataSourceWorkloadPlans_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccDataSourceWorkloadPlans_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceWorkloadPlans_basic
=== PAUSE TestAccDataSourceWorkloadPlans_basic
=== CONT  TestAccDataSourceWorkloadPlans_basic
--- PASS: TestAccDataSourceWorkloadPlans_basic (347.68s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws       347.732s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@wuzhuanhong
Copy link
Contributor Author

make testacc TEST=./huaweicloud/services/acceptance/dws TESTARGS='-run TestAccDataSourceWorkloadPlans_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/dws -v -run TestAccDataSourceWorkloadPlans_basic -timeout 360m -parallel 4
=== RUN TestAccDataSourceWorkloadPlans_basic
=== PAUSE TestAccDataSourceWorkloadPlans_basic
=== CONT TestAccDataSourceWorkloadPlans_basic
--- PASS: TestAccDataSourceWorkloadPlans_basic (281.04s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/dws 281.105s

ruwenqiang123
ruwenqiang123 reviewed Aug 13, 2024
View reviewed changes
docs/data-sources/dws_workload_plans.md Outdated

* `name` - The name of the workload plan.

* `cluster_id` - The cluster ID of to which the workload plan belongs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `cluster_id` - The cluster ID of to which the workload plan belongs.
* `cluster_id` - The cluster ID to which the workload plan belongs.

docs/data-sources/dws_workload_plans.md Outdated
* `cluster_id` - (Required, String) Specifies the DWS cluster ID to which the workload plans belong.

* `logical_cluster_name` - (Optional, String) Specifies the logical cluster name to which the workload plans belong.
This parameter is only available when The DWS cluster is logical cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This parameter is only available when The DWS cluster is logical cluster.
This parameter is only available when the DWS cluster is logical cluster.

@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2024
github-ci-robot
github-ci-robot approved these changes Aug 15, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit f1ff8ec into huaweicloud:master Aug 15, 2024
14 checks passed
@wuzhuanhong wuzhuanhong deleted the plans branch August 27, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruwenqiang123 ruwenqiang123 ruwenqiang123 left review comments

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wuzhuanhong @Lance52259 @ruwenqiang123 @github-ci-robot