Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(identitycenter): add resource identitycenter provision permssion set #6067

Merged
merged 1 commit into from
Dec 25, 2024
Merged

feat(identitycenter): add resource identitycenter provision permssion set #6067

merged 1 commit into from
Dec 25, 2024

Conversation

luoping-12345
Copy link
Contributor

@luoping-12345 luoping-12345 commented Dec 20, 2024 •
edited
Loading

What this PR does / why we need it:
add resource identitycenter provision permssion set

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

add resource identitycenter provision permssion set

PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/identitycenter' TESTARGS='-run TestAccProvisionPermissionSet_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/identitycenter -v -run TestAccProvisionPermissionSet_basic -timeout 360m -parallel 4
=== RUN   TestAccProvisionPermissionSet_basic
=== PAUSE TestAccProvisionPermissionSet_basic
=== CONT  TestAccProvisionPermissionSet_basic
--- PASS: TestAccProvisionPermissionSet_basic(54.03s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/identitycenter 71.547s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-actions github-actions bot added size/L and removed size/M labels Dec 23, 2024
@luoping-12345 luoping-12345 force-pushed the idc_pre_permit_set branch 3 times, most recently from 8372fa4 to 0a06f84 Compare December 24, 2024 02:49
@luoping-12345 luoping-12345 changed the title feat(identitycenter): add datasource identitycenter provisioned permssion sets feat(identitycenter): add resource identitycenter provision permssion set Dec 24, 2024
@WangLiNaruto
Copy link

LGTM

1 similar comment
@Alice1319
Copy link

LGTM

@luoping-12345 luoping-12345 force-pushed the idc_pre_permit_set branch 3 times, most recently from 45574cc to d5a3af2 Compare December 24, 2024 11:11
@luoping-12345 luoping-12345 force-pushed the idc_pre_permit_set branch 3 times, most recently from 1f907dd to d25b85d Compare December 25, 2024 03:03
@houpeng80
Copy link
Collaborator

/lgtm

@houpeng80 houpeng80 closed this Dec 25, 2024
@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 25, 2024
@houpeng80 houpeng80 reopened this Dec 25, 2024
@github-ci-robot github-ci-robot removed the LGTM /lgtm label Dec 25, 2024
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 25, 2024
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2024
github-ci-robot
github-ci-robot approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit 29affdf into huaweicloud:master Dec 25, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houpeng80 houpeng80 houpeng80 left review comments

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@luoping-12345 @WangLiNaruto @Alice1319 @houpeng80 @Jason-Zhang9309 @github-ci-robot