Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CodeArts/Deploy): support to get application groups #6086

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Dec 24, 2024

What this PR does / why we need it:
support to get application groups
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

support to get application groups

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/codeartsdeploy" TESTARGS="-run TestAccDataSourceCodeartsDeployApplicationGroups_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/codeartsdeploy -v -run TestAccDataSourceCodeartsDeployApplicationGroups_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceCodeartsDeployApplicationGroups_basic
=== PAUSE TestAccDataSourceCodeartsDeployApplicationGroups_basic
=== CONT  TestAccDataSourceCodeartsDeployApplicationGroups_basic
--- PASS: TestAccDataSourceCodeartsDeployApplicationGroups_basic (42.48s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/codeartsdeploy    42.527s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@saf3dfsa saf3dfsa force-pushed the feat(CodeArts/Deploy)_support_to_get_application_groups branch 2 times, most recently from c25a5e7 to e928c78 Compare December 24, 2024 12:06
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@saf3dfsa saf3dfsa force-pushed the feat(CodeArts/Deploy)_support_to_get_application_groups branch from e928c78 to 6ada4a4 Compare December 26, 2024 06:56
@houpeng80
Copy link
Collaborator

/lgtm
/approve

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 26, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/lgtm
/approve

@github-ci-robot github-ci-robot merged commit 0024aeb into huaweicloud:master Dec 26, 2024
14 checks passed
@saf3dfsa saf3dfsa deleted the feat(CodeArts/Deploy)_support_to_get_application_groups branch December 26, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants