Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1070 ang upgrade #1072

Merged
merged 45 commits into from
Sep 6, 2023
Merged

1070 ang upgrade #1072

merged 45 commits into from
Sep 6, 2023

Conversation

pbrm4
Copy link
Contributor

@pbrm4 pbrm4 commented Jul 26, 2023

No description provided.

@bherr2
Copy link
Member

bherr2 commented Aug 16, 2023

@edlu77 update the github action workflows to use node 18 (you'll see where it's using 14 and should be easy to update)

@bherr2
Copy link
Member

bherr2 commented Aug 17, 2023

Try to address most of the 225 code smells that sonarcloud is recommending as part of this too

@edlu77 edlu77 marked this pull request as ready for review August 30, 2023 14:50
@edlu77 edlu77 requested a review from bherr2 August 30, 2023 14:50
@bherr2
Copy link
Member

bherr2 commented Aug 30, 2023

Obvious style things to fix, but otherwise seems to work functionally. Seems a little slower/less responsive, but could just be my machine right now.

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

64.9% 64.9% Coverage
0.4% 0.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bherr2 bherr2 merged commit d22fece into develop Sep 6, 2023
3 of 4 checks passed
@bherr2 bherr2 deleted the 1070-ang-upgrade branch September 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants