Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hybrid database for fetching requests #1224

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Use hybrid database for fetching requests #1224

merged 8 commits into from
Feb 5, 2024

Conversation

edlu77
Copy link
Collaborator

@edlu77 edlu77 commented Jan 29, 2024

@edlu77 edlu77 requested review from axdanbol and bherr2 January 29, 2024 23:22
@edlu77 edlu77 self-assigned this Jan 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2024 •
edited
Loading

🚀 Preview Deploy Report Updated

✅ Successfully deployed preview here

bherr2
bherr2 reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@bherr2 bherr2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to make sure we don't have default data sources in environment anymore, since that would enable the hybrid option always.

axdanbol
axdanbol requested changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@axdanbol axdanbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor tweaks

projects/ccf-shared/src/lib/services/data-source/ccf-database.service.ts Outdated Show resolved Hide resolved
projects/ccf-shared/src/lib/services/data-source/ccf-database.service.ts Outdated Show resolved Hide resolved
projects/ccf-shared/src/lib/services/data-source/ccf-database.service.ts Outdated Show resolved Hide resolved
projects/ccf-shared/src/lib/services/data-source/api-endpoint.service.ts Outdated Show resolved Hide resolved
axdanbol
axdanbol requested changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@axdanbol axdanbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small tweaks

projects/ccf-shared/src/lib/services/data-source/ccf-database.service.ts Outdated Show resolved Hide resolved
projects/ccf-shared/src/lib/services/data-source/ccf-database.service.ts Outdated Show resolved Hide resolved
projects/ccf-eui/src/environments/environment.prod.ts Outdated Show resolved Hide resolved
projects/ccf-eui/src/environments/environment.staging.ts Outdated Show resolved Hide resolved
projects/ccf-eui/src/environments/environment.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@axdanbol axdanbol merged commit 8f40bec into develop Feb 5, 2024
2 of 3 checks passed
@axdanbol axdanbol deleted the eui-hybrid-database branch February 5, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bherr2 bherr2 bherr2 left review comments

@axdanbol axdanbol axdanbol approved these changes

Assignees

@edlu77 edlu77

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlu77 @axdanbol @bherr2