Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code after changes in scoringutils #52

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Fix code after changes in scoringutils #52

merged 4 commits into from
Sep 17, 2024

Conversation

nikosbosse
Copy link
Collaborator

@nikosbosse nikosbosse commented Sep 16, 2024

In epiforecasts/scoringutils#903 we changed the scoringutils behaviour surrounding the default metrics. This PR fixes the current code to conform with the new update.

I'll make additional suggestions in separate PRs.

I also fixed a failing test where scoringutils produced a warning in expect_equal. Sorry for that! Converting the data to data.frames avoids issues with scoringutils internally validating things it shouldn't be validating.

@nikosbosse nikosbosse requested a review from elray1 September 16, 2024 16:07
Copy link

github-actions bot commented Sep 16, 2024

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.43%. Comparing base (24b02b3) to head (937187a).
Report is 104 commits behind head on main.

Files with missing lines Patch % Lines
R/score_model_out.R 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #52       +/-   ##
==========================================
+ Coverage   0.00%   93.43%   +93.43%     
==========================================
  Files          2        5        +3     
  Lines         31      198      +167     
==========================================
+ Hits           0      185      +185     
+ Misses        31       13       -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@elray1 elray1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@elray1 elray1 merged commit ee0f9c1 into main Sep 17, 2024
8 checks passed
@elray1 elray1 deleted the scoringutils-hotfix branch September 17, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants