Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly list the chat template file in the Tokenizer saved files list #34974

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

Rocketknight1
Copy link
Member

@Rocketknight1 Rocketknight1 commented Nov 27, 2024

The tokenizer has a list of the files it saves, which wasn't correctly being updated with the new standalone chat template file. This PR fixes that issue!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this? 🤗

@Rocketknight1 Rocketknight1 force-pushed the correct_saved_files_list branch from 4461caa to 175eaa0 Compare January 7, 2025 16:22
@Rocketknight1 Rocketknight1 force-pushed the correct_saved_files_list branch from dbc4da3 to c465798 Compare January 7, 2025 18:41
@Rocketknight1
Copy link
Member Author

Test added!

@Rocketknight1 Rocketknight1 merged commit a7d1441 into main Jan 7, 2025
26 checks passed
@Rocketknight1 Rocketknight1 deleted the correct_saved_files_list branch January 7, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants