Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FillMaskPipeline.__call__ signature and docstring #35006

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

alvarobartt
Copy link
Member

What does this PR do?

This PR updates the FillMaskPipeline.__call__ signature to remove the unused *args and updates the docstrings accordingly, to use inputs over args.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

As it's related to a pipeline I'm assuming @Rocketknight1 (?), let me know otherwise!

- Remove unused `*args`
- Update docstring with `inputs` over `args`
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good spot! The existing docstring is quite confusing.

@Rocketknight1 Rocketknight1 merged commit 19dabe9 into huggingface:main Nov 29, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants