Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zoedepth initialization error under deepspeed zero3 #35011

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Tavish9
Copy link

@Tavish9 Tavish9 commented Nov 29, 2024

What does this PR do?

This PR addresses an issue with the initialization of tensor shapes in the ZoeDepth model when using the DeepSpeed framework with ZeRO-3 optimization.

Under DeepSpeed ZeRO-3, model parameters are partitioned, and the torch.Tensor class’s initialization behavior is overridden (details can be found in here). This override alters the behavior of tensor initialization, causing the error of the following line:

self.register_buffer("k_minus_1", torch.Tensor([self.k - 1]).view(1, -1, 1, 1), persistent=False)
print(self.k_minus_1.shape)  # torch.Size([1, 63, 1, 1]) wrong!

To resolve this, the initialization has been updated to use torch.tensor instead of torch.Tensor, which preserves the intended shape under DeepSpeed ZeRO-3.

self.register_buffer("k_minus_1", torch.tensor([self.k - 1]).view(1, -1, 1, 1), persistent=False)
print(self.k_minus_1.shape)  # torch.Size([1, 1, 1, 1]) correct!

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

cc @muellerzr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants