Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizer responsive exceeds maxSize boundary #3

Open
2 tasks
kdevo opened this issue Oct 30, 2021 · 0 comments
Open
2 tasks

Resizer responsive exceeds maxSize boundary #3

kdevo opened this issue Oct 30, 2021 · 0 comments
Labels
bug Something isn't working
Milestone
v1

Comments

@kdevo
Copy link
Member

kdevo commented Oct 30, 2021

When using the resizer responsive with responsiveSizes exceeding maxSize, one image after maxSize is included in the resulting image set.

Reproduction

Example config:

maxSize: 1000x
responsiveSizes: ["512x", "1024x", "1280x"]
  • Want images: ["512x"] (maybe it also makes sense to include the "1000x" here?)
  • Got images: ["512x", "1024x"]

Resolution

  • Ensure that no image exceeds user-defined maxSize for responsive resizer
  • Ensure consistency for other resizers, too
@kdevo kdevo added the bug Something isn't working label Oct 30, 2021
@kdevo kdevo added this to the v1 milestone Oct 30, 2021
@kdevo kdevo changed the title Resizer "responsive" exceeds maxSize boundary Resizer responsive exceeds maxSize boundary Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1
Development

No branches or pull requests
1 participant
@kdevo