Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to comment the PR with some information about the Env, Apps, DNS, etc. #10

Open
mathieu-benoit opened this issue Jul 13, 2023 · 2 comments

Comments

@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Jul 13, 2023

It would be great if we could have a dedicated action that we could use to comment the PR with insightful information like:

  • View in Humanitec - link to the
  • EnvId
  • List and links of all the DNS of the App deployed
  • Deployment Diff/Output
  • ...

This is a typically workflow with PR for testing feature branch, especially with new/ephemeral envs.

Something around these lines (credit to @williamoverton for that!), see attached.
image

Kind of different from create and notify, why not comment, comment-summary or `get-summary?

This action could/should wait for the in-progress Deployment.

Kind of what is done in there: https://github.com/Humanitec-DemoOrg/ephemeral-env-demo/blob/main/.github/workflows/pull_request.yaml.

@johanneswuerbach
Copy link
Contributor

In our testing we found comments fairly annoying as they trigger notifications and we went with the github deployment api instead to show the link to the deployed app and deployment in Humanitec.

Nevertheless it might be worth to make this an opt-in feature.

@mathieu-benoit
Copy link
Contributor Author

mathieu-benoit commented Jul 13, 2023

yep, exactly, explicit action, that user can use or not, more options :)

As a Developer:

I don't have to open Humanitec to grab the URL in order to test my app and see that I haven't broken anything. I can just click on the URL provided in the PR's comment.

I have also seen GHA removing previous comment if same as the new one added, to avoid too many comments as you will do many commits in one PR for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants