Skip to content
This repository has been archived by the owner on Oct 13, 2020. It is now read-only.

Multiple filters #135

Open
yumyo opened this issue Aug 5, 2016 · 0 comments
Open

Multiple filters #135

yumyo opened this issue Aug 5, 2016 · 0 comments

Comments

@yumyo
Copy link

yumyo commented Aug 5, 2016

Hi,

to enable to multiple filters (Blur, greyscale, smooth and pixelate) I am basically repeating four times the greyscale example filter. It comes with the following double check if ( ! is_a( $editor, 'WP_Image_Editor_GD' ) || empty( $args['greyscale'] ) )
I am wondering why not using a positive condition like
if ( is_a( $editor, 'WP_Image_Editor_GD' ) || !empty( $args['greyscale'] ) ) so it would be easy to enable all the filters at once.
Is there any specific down side to be aware of?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant