You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 13, 2020. It is now read-only.
to enable to multiple filters (Blur, greyscale, smooth and pixelate) I am basically repeating four times the greyscale example filter. It comes with the following double check if ( ! is_a( $editor, 'WP_Image_Editor_GD' ) || empty( $args['greyscale'] ) )
I am wondering why not using a positive condition like if ( is_a( $editor, 'WP_Image_Editor_GD' ) || !empty( $args['greyscale'] ) ) so it would be easy to enable all the filters at once.
Is there any specific down side to be aware of?
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi,
to enable to multiple filters (Blur, greyscale, smooth and pixelate) I am basically repeating four times the
greyscale
example filter. It comes with the following double checkif ( ! is_a( $editor, 'WP_Image_Editor_GD' ) || empty( $args['greyscale'] ) )
I am wondering why not using a positive condition like
if ( is_a( $editor, 'WP_Image_Editor_GD' ) || !empty( $args['greyscale'] ) )
so it would be easy to enable all the filters at once.Is there any specific down side to be aware of?
The text was updated successfully, but these errors were encountered: