Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hopefully finalize semantic release #244

Merged
merged 3 commits into from
Nov 18, 2024
Merged

fix: hopefully finalize semantic release #244

merged 3 commits into from
Nov 18, 2024

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Nov 15, 2024 •
edited
Loading

I think i may finally have it figured out.

So long as the GH_TOKEN has full permission, this should work.

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 17, 2024

@humbertogontijo

@Lash-L Lash-L merged commit 481f01d into main Nov 18, 2024
7 checks passed
@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 18, 2024

@humbertogontijo does the GH_TOKEN you made have full permissions? It is unable to push to the main branch as it is protected

@humbertogontijo
Copy link
Owner

Can you try it one more time?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 18, 2024

Same problem

                GitCommandError: Cmd('git') failed due to:                  
                exit code(1)                                                
                  cmdline: git push                                         
                https://github.com/humbertogontijo/python-                  
                roborock main                                               
                  stderr: 'remote: error: GH006: Protected                  
                branch update failed for refs/heads/main.                   
                remote:                                                     
                remote: - Changes must be made through a                    
                pull request.                                               
                To                                                          
                https://github.com/humbertogontijo/python-                  
                roborock                                                    
                 ! [remote rejected]     main -> main                       
                (protected branch hook declined)                            
                error: failed to push some refs to                          
                'https://github.com/humbertogontijo/python                  
                -roborock''

@humbertogontijo
Copy link
Owner

It has all permissions now. Maybe this just won't work with protected branches?
What about using the automatically generated secrets.GITHUB_TOKEN again?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 19, 2024

My understanding is that GITHUB_TOKEN uses the permissions of the end user. Since I can't push to protected branches, it will fail. If you merge it in - it might work?

@Lash-L
Copy link
Collaborator Author

Lash-L commented Nov 19, 2024

I believe you can add the github actions bot to the list of users allowed to push to protected branches? Not sure off the top of my head and away from my PC now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humbertogontijo humbertogontijo humbertogontijo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lash-L @humbertogontijo