Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: container issue from api change and ci update #257

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

Lash-L
Copy link
Collaborator

@Lash-L Lash-L commented Dec 18, 2024

This fixes a broken change from api issues.

I also switched it back to GH_TOKEN, I don't have a real fix yet, but could you please merge it in, since you have permissions it should work.

@Lash-L
Copy link
Collaborator Author

Lash-L commented Dec 18, 2024

@humbertogontijo Can you approve + merge this one. I think if you merge it - everything should work correctly and I need to get this out

Copy link
Collaborator

@humbertogontijo humbertogontijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets try it

@humbertogontijo humbertogontijo merged commit b1e645d into main Dec 18, 2024
7 checks passed
@Lash-L
Copy link
Collaborator Author

Lash-L commented Dec 18, 2024

Looks like it worked.

So we got three options

  1. I continue trying to find a long term solution with keys and stuff (seems like a PITA)
  2. Everytime I make a PR, you just merge it in addition to approving it. We just need to make sure that when you approve it is ready for merging, so i need to be careful about what i push to PR branches
  3. You give me more permissions and then the ci pipeline should work for me.

Your call

@Lash-L
Copy link
Collaborator Author

Lash-L commented Dec 18, 2024

Either way @humbertogontijo do you want to merge in this one as well?

#253

@Lash-L
Copy link
Collaborator Author

Lash-L commented Jan 5, 2025

@humbertogontijo What are your thoughts about moving python-roborock to a github org?

Allen(from HA core team) is going to be helping out now I believe, so perhaps making it so that as long as any org owner (you, myself, or allen) approves the PR, it can be merged? That way I could approve his PRs or you could approve his PRs? He could approve mine or you could approve mine? etc.

@Lash-L
Copy link
Collaborator Author

Lash-L commented Jan 6, 2025

@humbertogontijo ^ I saw you joined the org, if this is somehting you want to go through with you'll need to transfer the repo to the org. I marked you as owner

@Lash-L
Copy link
Collaborator Author

Lash-L commented Jan 11, 2025

@humbertogontijo ^ I saw you joined the org, if this is somehting you want to go through with you'll need to transfer the repo to the org. I marked you as owner

@humbertogontijo gonna ping one more time on this as I know there has been a lot of activity so you could have missed it. If this isn't something you want to go through with just lmk

@humbertogontijo
Copy link
Collaborator

I don't know how I missed this so many times. Sorry
I moved the repo to the organization

@Lash-L
Copy link
Collaborator Author

Lash-L commented Jan 11, 2025

@humbertogontijo No worries! There was a lot happening in the repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants