-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: container issue from api change and ci update #257
Conversation
@humbertogontijo Can you approve + merge this one. I think if you merge it - everything should work correctly and I need to get this out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try it
Looks like it worked. So we got three options
Your call |
Either way @humbertogontijo do you want to merge in this one as well? |
@humbertogontijo What are your thoughts about moving python-roborock to a github org? Allen(from HA core team) is going to be helping out now I believe, so perhaps making it so that as long as any org owner (you, myself, or allen) approves the PR, it can be merged? That way I could approve his PRs or you could approve his PRs? He could approve mine or you could approve mine? etc. |
@humbertogontijo ^ I saw you joined the org, if this is somehting you want to go through with you'll need to transfer the repo to the org. I marked you as owner |
@humbertogontijo gonna ping one more time on this as I know there has been a lot of activity so you could have missed it. If this isn't something you want to go through with just lmk |
I don't know how I missed this so many times. Sorry |
@humbertogontijo No worries! There was a lot happening in the repo! |
This fixes a broken change from api issues.
I also switched it back to GH_TOKEN, I don't have a real fix yet, but could you please merge it in, since you have permissions it should work.