Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polling Logic seems to look for all data #21

Open
vishalkuo opened this issue Sep 23, 2021 · 0 comments
Open

Polling Logic seems to look for all data #21

vishalkuo opened this issue Sep 23, 2021 · 0 comments

Comments

@vishalkuo
Copy link
Contributor

Describe the bug
According to the humio docs - polling is a single request that returns partial results from a query job.

The current behavior of the StaticQueryJob's poll is actually to continually poll until it receives the done message which is only actually sent when the job is completed. This causes issues since a request will take much longer than the actual timeout passed to this function.

that being said, the link that the client uses here is not what the API docs suggest (/dataspaces/{REPO} vs /repositories/{REPO}) which makes me think we might be using a legacy API, here?

Expected behavior
poll() should only make a request once. This method should actually be renamed to poll_until_completed or something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant