You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
several small fixes to get the old master branch version working with CMake. These are probably already fixed by your updates to main and therefore not as important. Ref: Running ns3-ai when using cmake to build ns3 #77
Most of them should be unproblematic changes and potentially be useful to others, so I'd like to merge these changes. However, in the meantime you folks have done a lot of awesome new work, to the point where most of the files modified by me don't even exist anymore. I can't properly open a PR on the main branch because I don't yet know where to look for, and have instead opened a PR on the old master branch (#101).
I would be very grateful if you could provide me some guidance in integrating these changes into the main branch and pack everything into a new release that comes with its own commit tag. I think it's reasonable to make it version 2.0 since the API seems very different now.
Thanks for your work!
The text was updated successfully, but these errors were encountered:
Hey there,
In my own fork I have made several small convenience improvements in the branch
flunzmas_ns3.36
to suit my own requirements:py_interface.py
)py_interface.py
). Ref: Option to release shared memory on python side with rollback #78perf
(changes to oldpy_interface.py
andns3_util.py
, more changes to oldns3_util.py
)psutil
version constraint (changes to oldsetup.py
)py_interface.py
, changes part 2 to oldpy_interface.py
)master
branch version working withCMake
. These are probably already fixed by your updates tomain
and therefore not as important. Ref: Running ns3-ai when using cmake to build ns3 #77Most of them should be unproblematic changes and potentially be useful to others, so I'd like to merge these changes. However, in the meantime you folks have done a lot of awesome new work, to the point where most of the files modified by me don't even exist anymore. I can't properly open a PR on the
main
branch because I don't yet know where to look for, and have instead opened a PR on the oldmaster
branch (#101).I would be very grateful if you could provide me some guidance in integrating these changes into the
main
branch and pack everything into a new release that comes with its own commit tag. I think it's reasonable to make it version 2.0 since the API seems very different now.Thanks for your work!
The text was updated successfully, but these errors were encountered: