Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dji/tello: fix the issue about Halt method #858

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Conversation

st-user
Copy link
Contributor

@st-user st-user commented Sep 25, 2022

This PR is intended to fix the issue: Dji Tello Halt does not terminate all the related goroutines and may wait forever when it is called multiple times #793.

This PR contains consecutive four commits.

…wait forever when it is called multiple times

Add failing unit tests.
…wait forever when it is called multiple times

Fix the issue.
…wait forever when it is called multiple times

Fix the test for Halt method so that it waits for all the related goroutines to complete.
…wait forever when it is called multiple times

Halt method waits forever when at least one of the goroutines is blocked by its Read method. To avoid this, I make Halt method close the connections before writing to doneCh.
@deadprogram
Copy link
Member

Thank you very much for this PR @st-user now merging.

@deadprogram deadprogram merged commit 7031d1e into hybridgroup:dev Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants