Upgrade to Edition 2024

[shadaj]

Lots of goodies, but we'll need to make sure nothing is broken.

[MingweiSamuel]

There are some clippy lints that flag problem spots before enabling

[MingweiSamuel]

Besides some small issues, main thing blocking is cargo test -p hydro_lang --doc --features deploy fails on some sort of trybuild issue

---- hydro_lang\src\stream.rs - stream::Stream<T,L,Unbounded,O>::union (line 1163) stdout ---- Error: "Failed to build crate (exit code: 101):\nerror[E0432]: unresolved import `hydro_lang::__staged::__doctest_35`\n --> src\\bin\\_process_0_B34660DE.rs:36:47\n |\n36 | use hydro_lang::__staged::__doctest_35::*;\n | ^^^^^^^^^^^^ could not find `__doctest_35` in `__staged`\n\nerror[E0432]: unresolved import `hydro_lang::__staged::__doctest_35`\n --> src\\bin\\_process_0_B34660DE.rs:141:55\n |\n141 | ... use hydro_lang::__staged::__doctest_35::*;\n | ^^^^^^^^^^^^ could not find `__doctest_35` in `__staged`\n\nFor more information about this error, try `rustc --explain E0432`.

[shadaj]

Oh no, this looks like a side effect of single compilation unit for doctests! Do you have a branch where I can play around with this? My best guess is we need to just disable staging logic for doctests as was done before.

[MingweiSamuel]

@shadaj Sure just pushed to https://github.com/hydro-project/hydro/tree/rust-2024-rustdoc

[shadaj]

Fix: #1743

[MingweiSamuel]

Workspace appears to be Rust 2024 ready now after #1737 #1743 #1744, PR soon

[jhellerstein]

Nice!

[MingweiSamuel]

49a387d #1747

[MingweiSamuel]

@shadaj It is apparently also an option to use rust,standalone_crate as the code snippet language to prevent combining of tests:

https://doc.rust-lang.org/edition-guide/rust-2024/rustdoc-doctests.html#standalone_crate-tag

[shadaj]

That won't actually fix the bug, we had the same limitation in Rust 2021 just it surfaces differently now.