fix(paxos): use Instant instead of SystemTime to ensure monotonic clock
#1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
15c1dc5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://869b31b2.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1588.hydroflow.pages.dev |
davidchuyaya
approved these changes
Nov 22, 2024
shadaj
force-pushed
the
pr1588
branch
5 times, most recently
from
a23d6b5 to
b5f46c3
Compare
… clock `SystemTime` is not guaranteed to be monotonic, which can cause trouble when measuring elapsed time for latency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SystemTimeis not guaranteed to be monotonic, which can cause trouble when measuring elapsed time for latency.