feat(hydroflow): add repeat_n(n) windowing operator, modify scheduler
#1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingweiSamuel
force-pushed
the
repeat-n
branch
from
d973a9b to
812edca
Compare
MingweiSamuel
changed the title
repeat_n() windowing operator, modify schedulerrepeat_n(n) windowing operator, modify scheduler
|
Just checking: if we reschedule the current subgraph, that will reset all internal operator state, right? |
Yeah, everything local will be reset, which is why we put stuff in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed a way for
repeat_nto repeat itself, so I've added a context apireschedule_current_subgraph, which works by tracking a single bit/boolafter each subgraph run. Therepeat_njust calls that method until it no longer needs to loop. This method differs fromschedule_subgraphin thatschedule_subgraphonly schedules for the next tick.