Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydrogen 0.97 crashes when using Jack 1.9.10 (Windows XP) #463

Open
E-Gwen opened this issue Jan 7, 2017 · 16 comments
Open

Hydrogen 0.97 crashes when using Jack 1.9.10 (Windows XP) #463

E-Gwen opened this issue Jan 7, 2017 · 16 comments

Comments

@E-Gwen
Copy link

E-Gwen commented Jan 7, 2017

No problem with portaudio.
But when you choose Jack as the audio system, Hydrogen 0.9.7 crashes or won't start.

I had to rewrite the hydrogen.cong file, line after <audio_engine>, to start Hydrogen anew.

So I manage to try the two audio engine in hydrogen, and Hydrogen will crash when you using Jack, so you can't use it with Ardour. Such a pity.

E-Gwen.

@guitman444
Copy link

Any updates on this? No new versions of Hydrogen released recently, and it still crashes with latest version of Jack installed.

@trebmuh
Copy link
Member

trebmuh commented Mar 22, 2018

@E-Gwen @guitman444 : can you guys please try it again with the beta1 for the future Hydrogen 1.0.0 and report if it's still happening? See here.

@mauser
Copy link
Member

mauser commented Mar 22, 2018

The current windows installers for 1.0.0-beta1 do not have jack support, so it is pointless at the moment to try if this issue is fixed.

@trebmuh
Copy link
Member

trebmuh commented Mar 22, 2018

Oh that's right, I forgot that! I've added a note about it on the 1.0.0-beta1release assets.

@OlivierCharton
Copy link

OlivierCharton commented Dec 11, 2019

Is this fixed in any way ? I can use Hydrogen just fine but as soon as I enable Jack, I got errors.

So far :

  • if I start all programs normally and try to use Jack audio on Hydrogen, I have the popup or Hydrogen just won't start

  • starting Hydro in admin mode and Jack in normal mode will display popup and a message on Jack
    Cannot open client Cannot connect to named pipe = \\.\pipe\client_jack_Hydrogen_0 err = 5 Cannot connect client pipe Cannot connect to client name = Hydrogen

  • starting hydrogen normally and Jack as admin makes Hydrogen pop the error

  • starting everything in admin mode makes Hydrogen to simply not start in Jack audio mode, or
    crash and stop if I switch it from Auto

I tried to edit hydrogen.conf but it didn't work

Any workaround ?

@theGreatWhiteShark
Copy link
Contributor

Hey @OlivierCharton

This issue is quite old by now. Could you check whether this bug still applies to the newest 1.1.1 release of Hydrogen? Otherwise, I will close this issue in two weeks. (but feel free to reopen it)

@OlivierCharton
Copy link

Hey

I moved to Linux after this post as I was not able to resolve the issue, and now that I'm back to Windows I do not use Hydrogen anymore so unfortunately I cannot tell.

Feel free to close the issue !

@E-Gwen
Copy link
Author

E-Gwen commented Jan 3, 2022

Hi,

I try the 1.1.1 32 bit version, and I got this error message :

"The procedure entry point GetTickCount64 could not be located in the dynamic link library KERNEL32.dll"

I try every windows binary version since 1.0.0b1, and I got an error message, so I can't open new Hydrogen version on Windows XP.

Thank you by taking care of.
Cheers.

@theGreatWhiteShark
Copy link
Contributor

Hey @E-Gwen ,

thanks for your reply!

I try every windows binary version since 1.0.0b1, and I got an error message, so I can't open new Hydrogen version on Windows XP.

Unfortunately, the current version of the framework we are using (Qt5) is not compatible with Windows XP anymore. I'm afraid there is not much we can do about it. AFAIKS it would require to built a custom Qt5 version in our tool chain (MSYS2 ships only Qt5.15.2) which probably won't possible using the open source trial (I think there is a time limit the jobs have to be finished in and building Qt5 takes many hours). In addition, we would need adapt the code base to work with both old and newer versions. This, however, might very well turn out to be unfeasible for our small team. Sorry.

Do you have another Windows machine? JACK support should work with all supported Windows systems.

@cme What's your take on the XP support? How about we add some notes to website/sourceforge etc. to note that it is only supported till 0.9.7?

@cme
Copy link
Contributor

cme commented Jan 4, 2022

Appveyor actually have legacy Qt installs available in the standard Windows VM images, which I see includes 5.6.3 (latest with XP support) though I guess it's probably not built with the XP support enabled.

(As an aside, we could probably save about a minute in the Windows builds by using one of these pre-installed Qts rather than installing the MSYS2 one, but it's a small fraction of the overall time. Though most of the time in those jobs is spent installing dependencies, especially on macOS 😦)

I don't have a feel for how much work it would be to work around older versions -- I have a vague memory that recent Qt versions have enabled some code cleanup, which might be more of a pain to work around than the occasional new feature that could be skipped.

@theGreatWhiteShark
Copy link
Contributor

Appveyor actually have legacy Qt installs available in the standard Windows VM images, which I see includes 5.6.3 (latest with XP support) though I guess it's probably not built with the XP support enabled.

Hmm. That's maybe worth a shot. There was also a request for XP support on the mailing list (more or less) recently and a lot of people around the world do not have access to more recent equipment. I'll compile a 5.6.3 version of Qt locally and try to get an idea of how much work this would be. By skimming through the ChangeLog of Qt5 it seems mostly QtQuick, QML, and QtWebengine stuff was updated. For QtCore and QtGUI it looked like mostly cosmetic stuff and little enhancements.

I'll also send a mail to the AppVeyor customer support and ask whether there 5.6.3 is compiled with XP support. Would be an overkill to port Hydrogen just to test this. AFAICS custom build images are quite pricey and not available in our OpenSource trial (no idea why they don't allow for 1-2 but instead let us heavily use their infrastructure to build dependencies)..

At some point we probably will head on to Qt6 and have to drop (potential) XP support. But 5.15 is still officially supported for the next 1.5 years.

@E-Gwen Would you have time/capacity to test a XP version of Hydrogen if we would manage to come up with one during the next weeks?

@E-Gwen
Copy link
Author

E-Gwen commented Jan 5, 2022 via email

@theGreatWhiteShark
Copy link
Contributor

I'll also send a mail to the AppVeyor customer support and ask whether there 5.6.3 is compiled with XP support.

I received word from the customer support

That’s a good question! :)

Honestly, I’m not an expert in Qt toolkit, so I’m afraid I can’t answer your question right away without googling. The only way for you to know if XP is supported is to give it a try.

Not helpful at all. So, maybe it is enabled but probably not since it's not part of the default options.

@theGreatWhiteShark
Copy link
Contributor

I don't have a feel for how much work it would be to work around older versions -- I have a vague memory that recent Qt versions have enabled some code cleanup, which might be more of a pain to work around than the occasional new feature that could be skipped.

The workload required - or let's say parts that need work - where definitely not what I was expecting. Using the codebase on master we need to change only two lines in a trivial way (see https://github.com/hydrogen-music/hydrogen/tree/phil-windows-xp-support-artifacts). But the AppVeyor image is bricked and pacman is not working. Since I'm no expert in either Windows or MSYS2 I do some try and error using solutions I found on StackOverflow. I'll continue on Monday but it may need a couple of days till there is a usable result.

@cme
Copy link
Contributor

cme commented Jan 15, 2022

Excellent!

@theGreatWhiteShark
Copy link
Contributor

I was tweaking the .appveyor build for the past week and I'm afraid this is a dead end. MSYS2 state they only support the Visual Studio 2019 image or newer (but AppVeyor does only provide their prebuilt Qt5.6.3 in older images).

When manually installing a newer version of pacman and disabling all GPG key checking of packages and databases I was able to download most of the required packages. Only libsndfile is not available as it depends on a more recent C++ library than shipped with the image. So, I also manually download a libsndfile release and used it in the compilation. But the linking of the hydrogen-core.dll does not work with both the most recent and the oldest available Windows release of libsndfile - although I don't whether this is the cause of the error. https://ci.appveyor.com/project/mauser/hydrogen/builds/42303747

I think I'll draw a line here. After all, it's improbable to find XP support to be enabled in the Qt version preinstalled there and it still smells like a lot of work. But in general, we could make Hydrogen support XP if we would have working environment. Our code base is not a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants