Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Ok type from FSMap methods add, delete and update. #82

Open
aaraney opened this issue Sep 27, 2021 · 1 comment
Open

Return Ok type from FSMap methods add, delete and update. #82

aaraney opened this issue Sep 27, 2021 · 1 comment

Comments

@aaraney
Copy link
Member

aaraney commented Sep 27, 2021

perhaps instead of raising a custom error, you can log a WARN when your condition is not met. Or maybe an assert instead of if?

Originally posted by @sblack-usu in #80 (comment)

@aaraney
Copy link
Member Author

aaraney commented Jan 12, 2022

Im going to leave this open. I think this is still relevant and one of the first features that should be addressed next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant