-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Portable build tool / Windows testing #1026
Merged
Merged
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
87dc481
Try to make TestGeneratorPlugin portable
dabrahams 7dbcdc6
Try enabling Windows testing in CI
dabrahams da73fdd
Remove unworkable dependency on Windows
dabrahams db4ab20
Fix spell-o
dabrahams 9972086
Merge branch 'main' of github.com:val-lang/val into portable-build-tool
dabrahams 91ea5cd
Windows fixen
dabrahams 3232ffd
Nix a little debug output
dabrahams e011682
Run tests on Windows
dabrahams 7b3f6b2
Try to make Windows CI work.
dabrahams 8ffb4b8
Stop trying to use cmd shell
dabrahams d507da2
Fix workflow syntax
dabrahams ce64550
Properly invoke quoted path in Powershell
dabrahams 8c3f0ee
Try using the standard Swift setup to get v 5.9
dabrahams 1ff2b5e
Try getting 5.9 with compnerd's action
dabrahams 36fabb3
Fix branch/tag spec
dabrahams acf8ed7
Attempt to use a dev snapshot on Windows
dabrahams 0d63e25
Darn tag name is not a tag name
dabrahams 62e8963
Try using a Browser Company build of Swift
dabrahams 15344fa
Fix install-swift invocation
dabrahams 3c5d1e4
Merge branch 'main' of github.com:hylo-lang/hylo into portable-build-…
dabrahams aa24faf
Add missing github-token
dabrahams d327742
Try invoking swift with the cmd shell
dabrahams c0c78cd
Gather more diagnostic information from the GitHub Windows runner.
dabrahams 2ec4ca7
Attempt to properly represent filesystem paths.
dabrahams 76a57be
Nix nonportable autoreleasepool
dabrahams a9ff0b5
Try to work around SPM relative path problem, maybe.
dabrahams e015200
Try to work around issue in CI by using relative paths.
dabrahams 0a113d9
Try *not* disabling the sandbox on Windows
dabrahams 67f2bfd
Fix relative path computation for different drives.
dabrahams 615f4ba
fix think-o
dabrahams 086ac91
Revert relative path shenanigans
dabrahams 5611f1c
Merge branch 'portable-build-tool' of github.com:hylo-lang/hylo into …
dabrahams 15b8e02
Merge branch 'portable-build-tool' of file:///z:/src/hylo into portab…
dabrahams a6e13e4
Try skipping the build when testing
dabrahams 6be1064
--skip-build, not --skip-tests
dabrahams 0955205
Attempt to make Windows reentrant build work.
dabrahams 7e8d1db
Make reentrant build of build tools optional on Windows.
dabrahams aa742b0
Turn reentrant builds off in CI for speed.
dabrahams 7247cb6
Merge branch 'main' of github.com:hylo-lang/hylo into portable-build-…
dabrahams 3d1b14c
Merge branch 'portable-build-tool' from Mac into portable-build-tool
dabrahams d3cb14f
Verbose diagnostics for llvm work.
dabrahams 125168a
Disable Windows testing until we can make it pass.
dabrahams 742a8f3
Enable as many tests on Windows as will pass.
dabrahams 753e63a
Merge branch 'main' of github.com:hylo-lang/hylo into portable-build-…
dabrahams 38f1f86
Fix reporting about Windows build, add missing SPM dependency
dabrahams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -101,4 +101,4 @@ | |
} | ||
], | ||
"version" : 2 | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last time this change got merged it caused Windows to fail. That had been done because we couldn't write
GenerateHyloFileTests.main()
at the top level. My fix was to create themain.swift
file that this PR wants to remove. Is that change necessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's necessary. Use of
@main
is fine on all platforms if you pass the (required on all platforms but not enforced)--parse-as-library
option toswift
, as I have done inPackage.swift
.