Add 'UTF8Array' to the standard library #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyouko-taiga
force-pushed
the
utf8-array
branch
from
83bb5cb to
d325e87
Compare
The current implementation of `UTF8Array` can't be compiled in no-std mode because it uses `PointerToMutable.deallocate`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UTF8Arrayis designed to be the internal representation ofString. Implementation details are documented in the sources. The purpose of the inline and unowned storage representations is to have a way to for the compiler to generate static instances ofStringeventually.The proposed implementation doesn't support mutable operations yet (e.g., appending). My goal is to extend this type so that it can be used as a drop-in replacement for
Array<Int8>.