Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an IR instruction to switch over the contents of a union #1564

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

kyouko-taiga
Copy link
Contributor

Fixes #1504

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 28 lines in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (211d4e0) to head (29bf165).
Report is 4 commits behind head on main.

Files Patch % Lines
Sources/IR/Emitter.swift 61.11% 14 Missing ⚠️
Sources/IR/Operands/Instruction/UnionSwitch.swift 48.14% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1564      +/-   ##
==========================================
- Coverage   87.83%   87.65%   -0.18%     
==========================================
  Files         372      373       +1     
  Lines       22568    22614      +46     
==========================================
+ Hits        19822    19823       +1     
- Misses       2746     2791      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyouko-taiga
Copy link
Contributor Author

Coverage regression is due to the fact that we don't use the switch instruction anymore and that we only use union_discriminator in synthesized equality operators. We may consider removing both of these instructions but I'd rather do it with separate PRs.

@kyouko-taiga kyouko-taiga merged commit 0392eff into main Aug 22, 2024
14 of 16 checks passed
@kyouko-taiga kyouko-taiga deleted the union-switch branch August 22, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic if-let failurea
1 participant