Use a different action to setup swift on Linux. #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This analysis <swift-actions/setup-swift#591 (comment)> explains why I think it will work. An alternative would be to run it on Linux in the devcontainer, where Swift is already set up.
...than running this on a macOS builder.
dabrahams
force-pushed
the
format-check-on-mac
branch
from
a2f5e01
to
1ed4a94
Compare
dabrahams
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to stomp out the spurious format-check failures we've been seeing, that die in setup-swift.
An alternative would be to run the format check on MacOS, but that's expected to be slower. This analysis swift-actions/setup-swift#591 (comment) explains why I think it would work.
Another alternative would be to run it on Linux in the devcontainer, where Swift is already set up.