-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More clearly document how to get working HTTPS #1025
Comments
It seems like for most people, they'll want to migrate their crates to use reqwest instead of Hyper's HTTP client. Maybe this should be mentioned in the CHANGELOG and possibly temporarily the README. |
I've added some links to the release page: https://github.com/hyperium/hyper/releases/v0.10.0 Would likely also be useful in the docs somewhere, and a guide dedicated to it. |
What is the state of HTTPs clients based on tokio? |
I think the easiest right now is to use tokio-proto to layer tokio-tls under hyper, here's working sample: |
tokio-tls uses native-tls which isn't "as much in Rust as possible". |
@terrax-net at the moment, native TLS is a more secure solution than Rust ring/rustls due to rustls not having any security audits performed on it. When it reaches more maturity, it will definitely be a better default, but for now it's better to use native-tls. |
I would echo the comments on lack of TLS documentation in the examples. I would say that lots of people would be discouraged by that given how important TLS is in today's world. Having said that it seems that latest release of "tonic" project has a good and working example of how to use TLS with hyper. So in my app I copied some of the code from "tonic". I was wondering if that logic could be pulled into "hyper" library? |
I subscribe to this too. Setting up a Hyper server with TLS, is quite unclear. Some dedicated Hyper TLS documentation is necessary in my opinion. Some documentation exists in third party crates, but it is not always working and it is not "official" in the sense that Hyper itself should have a recommended way (or 2 (e.g Native and/or Rustls)) of doing TLS. Happy to help if guidance is provided. |
I've added a stub guide about connectors (https://hyper.rs/guides/1/client/connectors/), and a list of crates that provide TLS for hyper. Adding more to the guides is always appreciated! (#3411) |
If you're coming from a pre-0.10 hyper, you had working HTTPS out of the box; with 0.10 "some assembly required". It'd be great of the hyper website, and documentation included a pointer to hyper-native-tls (or some other option), and appropriate snippets for integration.
The text was updated successfully, but these errors were encountered: