Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper-util: Limit number of connections in Pool #3785

Open
kuznetsss opened this issue Nov 17, 2024 · 0 comments
Open

hyper-util: Limit number of connections in Pool #3785

kuznetsss opened this issue Nov 17, 2024 · 0 comments
Labels
C-feature Category: feature. This is adding a new feature.

Comments

@kuznetsss
Copy link

Is your feature request related to a problem? Please describe.
Connections pool may uncontrollably grow if client connects to many different hosts. There is a related issue in reqwest: seanmonstar/reqwest#2424

Describe the solution you'd like
I can see a few options here:

  • Replace idle: HashMap<Key, Vec<Idle>> by LruCache<Key, Vec<Idle>> in PoolInner
  • Replace idle: HashMap<Key, Vec<Idle>> by LruCache<Key, Idle> in PoolInner

Describe alternatives you've considered
Maybe this problem shouldn't be solved at hyper-util's level and users of the library (or reqwest) should create separate clients for each host (or set of hosts).

Additional context
I'm happy to submit a PR for the issue if the feature would be considered as useful. I already implemented the change in my fork but I'm ok to update it or implement another solution.

@kuznetsss kuznetsss added the C-feature Category: feature. This is adding a new feature. label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: feature. This is adding a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant