Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace logrus with a better maintained library #461

Open
dtoubelis opened this issue Aug 30, 2024 · 2 comments
Open

Replace logrus with a better maintained library #461

dtoubelis opened this issue Aug 30, 2024 · 2 comments

Comments

@dtoubelis
Copy link

Is your feature request related to a problem? Please describe.
Logrus library is no longer maintained and we have strict requiremend for use of third party components.

Describe the solution you'd like
Given that grule is a library rather than a standalone application, it should accept whatever logger is used by a higher level application and pass it to the library. This will assure consistent control over logging. Can youi make it to accept standard go Loger? The idea behind logrus was to provide structured logging but since there is no standard interface for it in golang - it should be avoided in a library.

Describe alternatives you've considered
There is no alternatives since logrus is hardcoded into grule.

Additional context
We currently have grule in a proof of concept state but inconsistent logging is one of the hurdles preventing adoption... (poor performance is another one but it is a separate topic :-)

@blib
Copy link

blib commented Oct 30, 2024

This does not mean Logrus is dead. Logrus will continue to be maintained for security, (backwards compatible) bug fixes, and performance (where we are limited by the interface).

@dtoubelis
Copy link
Author

dtoubelis commented Oct 30, 2024

This does not mean Logrus is dead. Logrus will continue to be maintained for security, (backwards compatible) bug fixes, and performance (where we are limited by the interface).

Whether it is dead or alive is not that important... the fact is that there are multiple logging libraries and even a one from core library in golang 1.22+ (slog), so probability that everybody will be using logrus as their logging library is quite low and nobody likes mixing multiple logging libraries with different logging formats and separate configurations in a single application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants