Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Single Command to Multi Command #1154

Open
haricnugraha opened this issue Oct 26, 2023 · 0 comments
Open

Migrate from Single Command to Multi Command #1154

haricnugraha opened this issue Oct 26, 2023 · 0 comments
Labels
enhancement New feature or request v2 Will resolve in version 2

Comments

@haricnugraha
Copy link
Contributor

haricnugraha commented Oct 26, 2023

Currently, Monika has too many flags. It starts cluttering the codebase. We need to separate unrelated flags from the main command. The idea is Monika will use multi command to isolate utility command like logs and flush.

As is (Single Command)

monika Command Flag

  • --auto-update
  • --config-filename
  • --config-interval
  • --config or -c
  • --create-config
  • --flush
  • --follow-redirects
  • --force
  • --har or -H
  • --help or -h
  • --id or -i
  • --insomnia or -I
  • --keep-verbose-logs
  • --logs or --l
  • --one-probe
  • --output or -o
  • --postman or -p
  • --prometheus
  • --repeat or -r
  • --retryInitialDelayMs
  • --retryMaxDelayMs
  • --sitemap
  • --status-notification
  • --stun or -s
  • --summary
  • --symon-api-version
  • --symonKey
  • --symonLocationId
  • --symonMonikaId
  • --symonReportInterval
  • --symonReportLimit
  • --symonUrl
  • --text
  • --verbose
  • --version or -v:

To be (Multi Command)

monika Command Flag

  • --auto-update
  • --config-filename
  • --config-interval replace with --config-interval-seconds
  • --config or -c
  • --follow-redirects
  • --har or -H
  • --help or -h
  • --id or -i
  • --insomnia or -I
  • --keep-verbose-logs
  • --one-probe
  • --output or -o
  • --postman or -p
  • --prometheus
  • --repeat or -r
  • --retryInitialDelayMs replace with retry-initial-delay-ms
  • --retryMaxDelayMs replace with retry-max-delay-ms
  • --sitemap
  • --status-notification
  • --stun or -s
  • --text
  • --verbose
  • --version or -v:

monika create-config Command Flag

  • --force

monika flush Command Flag

  • --force

monika logs Command

monika summary Command

monika symon Command Flag

  • --auto-update
  • --config-interval replace with --config-interval-seconds
  • --follow-redirects
  • --retryInitialDelayMs replace with retry-initial-delay-ms
  • --retryMaxDelayMs replace with retry-max-delay-ms
  • --symon-api-version replace with --api-version
  • --symonKey replace with --key
  • --symonLocationId replace with --location-id
  • --symonMonikaId replace with --monika-id
  • --symonReportInterval replace with --report-interval-ms
  • --symonReportLimit replace with --report-limit-mb
  • --symonUrl replace with --url
  • --verbose
@haricnugraha haricnugraha added enhancement New feature or request v2 Will resolve in version 2 labels Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2 Will resolve in version 2
Projects
None yet
Development

No branches or pull requests

1 participant