Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): fix DAST nuclei scan - besu connectivity issue #3596

Closed
petermetz opened this issue Oct 17, 2024 · 0 comments · Fixed by #3620
Closed

ci(github): fix DAST nuclei scan - besu connectivity issue #3596

petermetz opened this issue Oct 17, 2024 · 0 comments · Fixed by #3620
Assignees
@jagpreetsinghsasan
Labels
Besu github_actions Pull requests that update GitHub Actions code P1 Priority 1: Highest Security Related to existing or potential security vulnerabilities
Milestone
v2.0.1

Comments

@petermetz
Copy link
Contributor

petermetz commented Oct 17, 2024 •
edited
Loading

Description

It started failing on this pull request: #3587

Cannot be reproduced locally because it works fine there.

cacti-config.dast.json

urls.txt

2024-10-17T13-10-06-cacti-dast.crash.log

Acceptance Criteria

  1. The DAST scan works locally and on the CI as well (right now it fails on the CI)
  2. The nuclei package has been upgraded to the latest stable version (they've released a new major version in the meantime so we have to go from v2 to v3 latest stable - pinned down)
@petermetz petermetz added Besu Security Related to existing or potential security vulnerabilities P1 Priority 1: Highest github_actions Pull requests that update GitHub Actions code labels Oct 17, 2024
@petermetz petermetz mentioned this issue Oct 17, 2024
Merged
5 tasks
@petermetz petermetz added this to the v2.0.1 milestone Oct 18, 2024
@jagpreetsinghsasan jagpreetsinghsasan self-assigned this Oct 23, 2024
jagpreetsinghsasan pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Nov 7, 2024
ci(github): fix DAST scan besu connectivity
af97e98 
    Primary Changes
    --------------
    1. Hardcoded the localhost to 127.0.0.1 for
       the config.json file required to spin up
       cactus-cmd-api-server

    Secondary Changes
    -----------------
    2. Updated the verion of besu AIO
    3. Updated the version of nuclei

    Changes required to incorporate 3)
    ---------------------------------
    4. Updated the go version

Fixes hyperledger-cacti#3596

Signed-off-by: jagpreetsinghsasan <[email protected]>
@jagpreetsinghsasan jagpreetsinghsasan mentioned this issue Nov 7, 2024
Merged
5 tasks
petermetz pushed a commit to jagpreetsinghsasan/cactus that referenced this issue Nov 28, 2024
@petermetz
ci(github): fix DAST scan besu connectivity
8614d33 
    Primary Changes
    --------------
    1. Hardcoded the localhost to 127.0.0.1 for
       the config.json file required to spin up
       cactus-cmd-api-server

    Secondary Changes
    -----------------
    2. Updated the verion of besu AIO
    3. Updated the version of nuclei

    Changes required to incorporate 3)
    ---------------------------------
    4. Updated the go version

Fixes hyperledger-cacti#3596

Signed-off-by: jagpreetsinghsasan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jagpreetsinghsasan jagpreetsinghsasan

Labels
Besu github_actions Pull requests that update GitHub Actions code P1 Priority 1: Highest Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging a pull request may close this issue.

ci(github): fix DAST scan besu connectivity jagpreetsinghsasan/cactus
2 participants
@petermetz @jagpreetsinghsasan