Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): fix DAST scan besu connectivity #3620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(github): fix DAST scan besu connectivity #3620

wants to merge 1 commit into from

Conversation

jagpreetsinghsasan
Copy link
Contributor

Commit to be reviewed

ci(github): fix DAST scan besu connectivity

Primary Changes
--------------
1. Hardcoded the localhost to 127.0.0.1 for the config.json file
    required to spin up cactus-cmd-api-server

Secondary Changes
-----------------
3. Updated the verion of besu AIO
4. Updated the version of nuclei

Changes required to incorporate 3)
---------------------------------
5. Updated the go version

Fixes #3596

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

ci(github): fix DAST scan besu connectivity
af97e98 
    Primary Changes
    --------------
    1. Hardcoded the localhost to 127.0.0.1 for
       the config.json file required to spin up
       cactus-cmd-api-server

    Secondary Changes
    -----------------
    2. Updated the verion of besu AIO
    3. Updated the version of nuclei

    Changes required to incorporate 3)
    ---------------------------------
    4. Updated the go version

Fixes hyperledger-cacti#3596

Signed-off-by: jagpreetsinghsasan <[email protected]>
petermetz
petermetz approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagpreetsinghsasan Excellent! Thank you!

@jagpreetsinghsasan jagpreetsinghsasan requested a review from a team November 14, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermetz petermetz petermetz approved these changes

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

@outSH outSH Awaiting requested review from outSH outSH is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci(github): fix DAST nuclei scan - besu connectivity issue
2 participants
@jagpreetsinghsasan @petermetz