Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ghcr-example-supply-chain-app): fix missing patch @ionic-native #3601

Open
petermetz opened this issue Oct 24, 2024 · 0 comments · May be fixed by #3651
Open

test(ghcr-example-supply-chain-app): fix missing patch @ionic-native #3601

petermetz opened this issue Oct 24, 2024 · 0 comments · May be fixed by #3651
Assignees
Labels
bug Something isn't working Developer_Experience documentation Improvements or additions to documentation P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Milestone

Comments

@petermetz
Copy link
Contributor

Description

The container image build of the supply chain app example is broken on the CI.
This is most likely due to the outdated and hardcoded npm install versions within the image.

Logs

#13 9.610 ➤ YN0001: │ Error: @ionic-native/splash-screen@patch:@ionic-native/splash-screen@npm%3A5.36.0#~/.yarn/patches/@ionic-native-splash-screen-npm-5.36.0-531cbbe0f8.patch: ENOENT: no such file or directory, open '/usr/src/app/.yarn/patches/@ionic-native-splash-screen-npm-5.36.0-531cbbe0f8.patch'
#13 9.610 ➤ YN0000: └ Completed in 4s 81ms
#13 9.610 ➤ YN0000: · Failed with errors in 4s 98ms
ERROR: failed to solve: process "/bin/bash --login -i -c source ~/.bashrc &&     nvm install 18.18.2 &&     npm i -g corepack && corepack enable && corepack prepare [email protected] --activate &&     yarn init --yes --private &&     yarn config set nodeLinker node-modules &&     yarn add @hyperledger/cactus-example-supply-chain-backend@${NPM_PKG_VERSION} --exact &&     yarn add [email protected] --exact &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-test-tooling\": \"\\($NPM_PKG_VERSION)\" }' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-api-client\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-cmd-api-server\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-common\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-core\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-core-api\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-example-supply-chain-business-logic-plugin\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-example-supply-chain-frontend\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-plugin-consortium-manual\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-plugin-keychain-memory\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-plugin-ledger-connector-besu\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-plugin-ledger-connector-fabric\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     cat /usr/src/app/package.json | jq --arg NPM_PKG_VERSION ${NPM_PKG_VERSION} '.resolutions += { \"@hyperledger/cactus-plugin-ledger-connector-xdai\": \"\\($NPM_PKG_VERSION)\" } ' | sponge /usr/src/app/package.json &&     yarn install" did not complete successfully: exit code: 1

2024-10-24T20-01-00-cacti-ghcr-supply-chain-app-crash.log

Reproduction steps:

DOCKER_BUILDKIT=1 docker build . -f ./examples/cactus-example-supply-chain-backend/Dockerfile -t cactus-example-supply-chain-app

Acceptance Criteria

  1. The container image build is passing again.
@petermetz petermetz added bug Something isn't working documentation Improvements or additions to documentation Developer_Experience Tests Anything related to tests be that automatic or manual, integration or unit, etc. P2 Priority 2: High labels Oct 24, 2024
@petermetz petermetz added this to the v2.0.1 milestone Oct 24, 2024
@petermetz petermetz assigned petermetz and unassigned petermetz Oct 24, 2024
zondervancalvez added a commit to zondervancalvez/cactus that referenced this issue Nov 25, 2024
Primary Changes
----------------
1. Updated the NVM version to 20.11.1 and added
the necessary yarn patch path to build the image

Fixes hyperledger-cacti#3601

Signed-off-by: bado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Developer_Experience documentation Improvements or additions to documentation P2 Priority 2: High Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants