Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ghcr-example-supply-chain-app): fix missing patch @ionic-native #3651

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(ghcr-example-supply-chain-app): fix missing patch @ionic-native #3651

wants to merge 1 commit into from

Conversation

zondervancalvez
Copy link
Contributor

Commit to be reviewed

test(ghcr-example-supply-chain-app): fix missing patch @ionic-native

Primary Changes
----------------
1. Updated the NVM version to 20.11.1 and added
the necessary yarn patch path to build the image

Fixes #3601

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@zondervancalvez
test(ghcr-example-supply-chain-app): fix missing patch @ionic-native
7a16672 
Primary Changes
----------------
1. Updated the NVM version to 20.11.1 and added
the necessary yarn patch path to build the image

Fixes hyperledger-cacti#3601

Signed-off-by: bado <[email protected]>
@jagpreetsinghsasan
Copy link
Contributor

@zondervancalvez codegen is failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermetz petermetz Awaiting requested review from petermetz petermetz is a code owner

@izuru0 izuru0 Awaiting requested review from izuru0 izuru0 is a code owner

@jagpreetsinghsasan jagpreetsinghsasan Awaiting requested review from jagpreetsinghsasan jagpreetsinghsasan is a code owner

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

@outSH outSH Awaiting requested review from outSH outSH is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test(ghcr-example-supply-chain-app): fix missing patch @ionic-native
2 participants
@zondervancalvez @jagpreetsinghsasan