Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(github): fix TypeError: Failed to parse URL from undefined/commits #3613

Open
petermetz opened this issue Nov 1, 2024 · 0 comments
Open

ci(github): fix TypeError: Failed to parse URL from undefined/commits #3613

petermetz opened this issue Nov 1, 2024 · 0 comments
Assignees
@zondervancalvez
Labels
bug Something isn't working P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Milestone
v2.1.0

Comments

@petermetz
Copy link
Contributor

Description

The Check CI skip job is broken on the main branch. Probably because some of the code assumes that it is running in the context of a pull request.

Logs

2024-11-01T16-20-07-cacti-ci-check-skip.crash.log

Screenshot 2024-11-01 140235

Acceptance Criteria

  1. Check CI skip job works fine on the main branch too, not just on pull requests.
@petermetz petermetz added bug Something isn't working Tests Anything related to tests be that automatic or manual, integration or unit, etc. P3 Priority 3: Medium labels Nov 1, 2024
@petermetz petermetz added this to the v2.1.0 milestone Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zondervancalvez zondervancalvez

Labels
bug Something isn't working P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
v2.1.0
Development

No branches or pull requests
2 participants
@petermetz @zondervancalvez