Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use tshy to support both CJS and ESM dist artifacts #3616

Open
petermetz opened this issue Nov 4, 2024 · 0 comments
Open

build: use tshy to support both CJS and ESM dist artifacts #3616

petermetz opened this issue Nov 4, 2024 · 0 comments
Labels
backlog Tasks that are needed but we cannot prioritize them at present. P4 Priority 4: Low
Milestone

Comments

@petermetz
Copy link
Contributor

Description

We've struggled a lot with ESM/CJS incompatibilities and it's not a settled question still.

The scope of this task is to evaluate the tshy tool.

I've recently seen a new-ish tool that I haven't tried before that could help us with making CJS and ESM work together more seamlessly by refactoring the TS compilation output directory structure (or at least that's what it sounds like based on the first link)

Source 1: https://colinhacks.com/essays/live-types-typescript-monorepo
Source 2: https://github.com/isaacs/tshy

Acceptance Criteria

  1. The "are the types wrong" checks are passing.
  2. Build is not slower than before (or only a little bit slower if it must be)
  3. The watch scripts still work (yarn watch-tsc)

cc: @outSH

@petermetz petermetz added P4 Priority 4: Low backlog Tasks that are needed but we cannot prioritize them at present. labels Nov 4, 2024
@petermetz petermetz added this to the vT.B.D milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Tasks that are needed but we cannot prioritize them at present. P4 Priority 4: Low
Projects
None yet
Development

No branches or pull requests

1 participant