Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): fix type exports in packages/cactus-common #3635

Open
ruzell22 opened this issue Nov 13, 2024 · 0 comments · May be fixed by #3649
Open

ci(github): fix type exports in packages/cactus-common #3635

ruzell22 opened this issue Nov 13, 2024 · 0 comments · May be fixed by #3649
Assignees
Labels
bug Something isn't working P2 Priority 2: High Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Milestone

Comments

@ruzell22
Copy link
Contributor

Description

Relates to: #3140

Ignore pattern has been added in tools/custom-checks/get-all-tgz-path.ts in PR #3561 for packages that are having error when running the newly added check in custom-checks to validate exported types being correct so that the job will pass for now.

This ticket is created to fix packages/cactus-common/hyperledger-cactus-common-*.tgz and delete it in the ignore pattern right after. For more info about the custom-check log, refer to this github action link:
https://github.com/hyperledger-cacti/cacti/actions/runs/11798447068/job/32864671597?pr=3561

and this discussion reply:
#3561 (review)

Related link that can help with regards to the error logs:
https://www.npmjs.com/package/@arethetypeswrong/cli

Acceptance Criteria

  1. ci yarn-custom-checks should pass
  2. remove the ignore pattern for this specific package in tools/custom-checks/get-all-tgz-path.ts
@ruzell22 ruzell22 changed the title ci(github): fix tgz file in packages/cactus-common ci(github): fix type exports in packages/cactus-common Nov 13, 2024
@petermetz petermetz added bug Something isn't working Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc. P3 Priority 3: Medium P2 Priority 2: High and removed P3 Priority 3: Medium labels Nov 13, 2024
@petermetz petermetz added this to the v2.1.0 milestone Nov 13, 2024
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 21, 2024
Primary Changes
---------------
1. Remove packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore
paths in get-all-tgz-path.ts file
2. Added the missing LogLevelDesc in index.js and index.d.ts as per attw
-f json error log

Fixes: hyperledger-cacti#3635

Signed-off-by: ruzell22 <[email protected]>
@ruzell22 ruzell22 linked a pull request Nov 21, 2024 that will close this issue
5 tasks
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 21, 2024
Primary Changes
---------------
1. Remove packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore
paths in get-all-tgz-path.ts file
2. Added the missing LogLevelDesc in index.js and index.d.ts as per attw
-f json error log

Fixes: hyperledger-cacti#3635

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 21, 2024
Primary Changes
---------------
1. Remove packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore
paths in get-all-tgz-path.ts file
2. Added the missing LogLevelDesc in index.js and index.d.ts as per attw
-f json error log

Fixes: hyperledger-cacti#3635

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 21, 2024
Primary Changes
---------------
1. Remove packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore
paths in get-all-tgz-path.ts file
2. Added the missing LogLevelDesc in index.ts as per attw -f json error log

Fixes: hyperledger-cacti#3635

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 22, 2024
Primary Changes
---------------
1. Remove packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore
paths in get-all-tgz-path.ts file
2. Added the missing LogLevelDesc in index.ts as per attw -f json error log

Fixes: hyperledger-cacti#3635

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Nov 22, 2024
Primary Changes
---------------
1. Remove packages/cactus-common/hyperledger-cactus-common-*.tgz in ignore
paths in get-all-tgz-path.ts file
2. Added the missing LogLevelDesc in index.ts as per attw -f json error log

Fixes: hyperledger-cacti#3635

Signed-off-by: ruzell22 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2 Priority 2: High Triage_Needed Triage if the issue is/still relevant, bug report is valid, arch/design details etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants