Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the case when watcher returns before the channel is closed #197

Open
manoranjith opened this issue Jun 9, 2021 · 0 comments
Open

Handle the case when watcher returns before the channel is closed #197

manoranjith opened this issue Jun 9, 2021 · 0 comments
Labels
improvement Proposals to improve the software

Comments

@manoranjith
Copy link
Contributor

Motivation / Context

Currently, the watcher is started when a channel is opened (see newCh function in session/channel.go and assumed that it will only return after the channel instance from go-perun is closed. So we just log the error.

This assumption holds good for all our current tests cases, but the cases where the assumption will fail also should be handled. #### Description

Explore when this assumption can fail and handle the error for such cases. One possible scenario where it fails could be when connection to blockchain fails.

Relates to
@manoranjith manoranjith added the improvement Proposals to improve the software label Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Proposals to improve the software
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manoranjith