Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc api: Session close should also close corresponding listeners for proposal and updates #246

Open
danielksan81 opened this issue Jan 5, 2023 · 0 comments
Labels
improvement Proposals to improve the software

Comments

@danielksan81
Copy link
Contributor

Motivation / Context

In the current implementation a session can be closed and the listeners are still open.

Expectation is that only if a session is open, listeners are valid and existent.

Maybe an alternative option is to add a flag to the method (true/false), which is targeting closing corresponding listeners if set to true. Default it will be false and preserve open listeners.

Description

Session close should also contain the following logic:

  • Check for open channel proposal listeners for that session.
  • Close found channel proposal listeners.
  • Check for open channel update listeners.
  • Close found channel update listeners.
Relates to
@danielksan81 danielksan81 added the improvement Proposals to improve the software label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Proposals to improve the software
Projects
None yet
Development

No branches or pull requests

1 participant