Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Post timeout - Optimize the good path in DID Comm communication #246

Open
FabioPinheiro opened this issue Mar 4, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@FabioPinheiro
Copy link
Contributor

We need to restructure the code to optimize the good path when sending a DID Comm message via HTTP Post.

We have created an interface called Transport when a channel is open to receive/send DID Comm messages. As a way to uniform HTTP Posts and Websocket.

https://github.com/input-output-hk/atala-prism-mediator/blob/e032c3365f7b9ed0782bbd67a4f2809b40c18338/mediator/src/main/scala/io/iohk/atala/mediator/DIDCommRoutes.scala#L63-L71

We then pass this transport object to the underlying system for doing all the things necessary including problem reports.
Although, the way that we close the channel when he's there is no reply or problem to report is by a timeout.
This timeout should be removed but to do that we need to restructure the code, and put rules to close the Transport when there is no immediate need of it (in the case of HTTP Post)

@FabioPinheiro FabioPinheiro self-assigned this Apr 16, 2024
@FabioPinheiro FabioPinheiro added the enhancement New feature or request label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant