From c1b1d2a783d9b64c03411a1382e68c3699027fb1 Mon Sep 17 00:00:00 2001 From: Michael Breuninger Date: Fri, 27 Sep 2024 20:31:04 +0800 Subject: [PATCH 1/2] docs: update PR template Related to ATL-7849 and this is also a try to use a text edior to write the commit message on more than one line Signed-off-by: Michael Breuninger --- .github/PULL_REQUEST_TEMPLATE.md | 52 +++++++++++++++++++++++--------- 1 file changed, 38 insertions(+), 14 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b3ef28ba..1f303896 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,14 +1,38 @@ -### Description: -Summarize the changes you're submitting in a few sentences, including Jira ticket ATL-xxxx if applicable. -Link to any discussion, related issues, and bug reports to give the context and help the reviewer understand the PR. - -### Alternatives Considered (optional): -Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas. - -### Checklist: -- [ ] My PR follows the contribution guidelines of this project -- [ ] My PR is free of third-party dependencies that don't comply with the [Allowlist](https://toc.hyperledger.org/governing-documents/allowed-third-party-license-policy.html#approved-licenses-for-allowlist) -- [ ] I have commented my code, particularly in hard-to-understand areas -- [ ] I have made corresponding changes to the documentation -- [ ] I have added tests that prove my fix is effective or that my feature works -- [ ] I have checked the PR title to follow the [conventional commit specification](https://www.conventionalcommits.org/en/v1.0.0/) + + + +## What was changed and what it is solving + +## How it was tested + +## Release Notes / Changelog + +```markdown changelog + +``` + From 4b0454ac89696ad237e14b4701f8098933429aaa Mon Sep 17 00:00:00 2001 From: Yurii Shynbuiev Date: Fri, 27 Sep 2024 20:50:01 +0700 Subject: [PATCH 2/2] ci: update upload-artifact to v3 Signed-off-by: Yurii Shynbuiev --- .github/workflows/integration-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml index c61be90a..2e0a9a20 100644 --- a/.github/workflows/integration-tests.yml +++ b/.github/workflows/integration-tests.yml @@ -92,7 +92,7 @@ jobs: ./gradlew reports - name: Upload artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: e2e-tests-result path: ${{ env.REPORTS_DIR }}