Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Continuous improvement of repository collection #756

Open
3 of 10 tasks
andyhuang18 opened this issue Oct 26, 2023 · 4 comments
Open
3 of 10 tasks

[Feature] Continuous improvement of repository collection #756

andyhuang18 opened this issue Oct 26, 2023 · 4 comments
Assignees
Labels
kind/feature Category issues or prs related to feature request.

Comments

@andyhuang18
Copy link
Collaborator

andyhuang18 commented Oct 26, 2023

Description

Hi everyone~ The OSPP process has come to an end, but we still need to continue to improve and perfect the repo-collection function.

At present, there are several known improvement points:

  • Add the function of adding to a collection directly by entering the full name of the repo.
  • Smoothly solve the problem of adding new collections and editing collections.
  • Optimize the overlap problem between the exit button in the upper right corner of the collection panel and the scroll bar on the far right.
  • i18n.
  • Discuss token optimization issues.
  • Optimized style: The repository list on the left side of the collection panel theme is too narrow.
  • Set no data state for chart. Can refer to this Page.

For the chart section:

  • Implement repository-specific highlighting and unhighlighting
  • The chart adapts to changes in the container window size
  • Optimize the style of the SankeyChart

You are welcome to continue to pay attention to this new feature and make suggestions for modifications!

@andyhuang18 andyhuang18 added the kind/feature Category issues or prs related to feature request. label Oct 26, 2023
@wxharry
Copy link
Collaborator

wxharry commented Oct 27, 2023

Also, please show a different message for collections with no repo. For example, showing a message: "This collection has no repository." It looks buggy to have all these charts but got no data.

@tyn1998
Copy link
Member

tyn1998 commented Oct 28, 2023

Also, please show a different message for collections with no repo. For example, showing a message: "This collection has no repository." It looks buggy to have all these charts but got no data.

Empty can help :)

@wj23027
Copy link
Collaborator

wj23027 commented Nov 8, 2023

Here are some TODOs for the chart section:

  • Implement repository-specific highlighting and unhighlighting
  • The chart adapts to changes in the container window size
  • Optimize the style of the SankeyChart

@wxharry
Copy link
Collaborator

wxharry commented Nov 9, 2023

Bugs to be fixed:

  • Duplicte collection should not be created
  • Duplicate repo should not be added
  • Add a non-existing repo should give a message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or prs related to feature request.
Projects
None yet
Development

No branches or pull requests

4 participants