Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code pip installable #6

Open
cthoyt opened this issue Oct 27, 2020 · 2 comments · May be fixed by #7
Open

Make code pip installable #6

cthoyt opened this issue Oct 27, 2020 · 2 comments · May be fixed by #7

Comments

@cthoyt
Copy link

cthoyt commented Oct 27, 2020

It would be really useful if this code were pip-installable to make its installation and usage more reproducible. Would you be willing to accept a PR for this?
@hyren
Copy link
Owner

hyren commented Oct 27, 2020

Yes, thanks for your efforts! Also please check out this new repo https://github.com/snap-stanford/KGReasoning with GQE, Query2box and a new BetaE model (that handles negation). Feel free to let me know if you can provide a PR to that too. Thanks :)

@cthoyt cthoyt linked a pull request Dec 23, 2020 that will close this issue
Open
@cthoyt
Copy link
Author

cthoyt commented Dec 23, 2020

Hi @hyren, thanks for being patient. I've just made the PR for this repo and also I dod one for the KGReasoning repo too! Merry christmas from PR Santa :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make pip installable cthoyt-forks-and-packages/query2box
2 participants
@cthoyt @hyren