Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review #1

Open
michaelcarrano opened this issue Mar 28, 2015 · 0 comments
Open

Code Review #1

michaelcarrano opened this issue Mar 28, 2015 · 0 comments

Comments

@michaelcarrano
Copy link

  1. The coding style is good and has consistent style. I would try to make use of comments to it is easier to understand what the program is doing.
  2. You could replace many while loops with if-else statements. For example, these lines can most likely be changed to if/if-else statements and still have the same results. #L19, #L28, #L41, etc
  3. It looks like if we simply change our logic from while(numOfTries > 1) to while(numOfTries > 0) on #L15 then we can remove all of this duplicated code.
  4. This would be a good place to use an if statement - #L208-210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant