Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace to_string and from_string with more descriptive terms - e.g. to_fen #4

Open
Tracked by #8
iCodeSometime opened this issue Nov 26, 2022 · 1 comment
Open
Tracked by #8

Replace to_string and from_string with more descriptive terms - e.g. to_fen #4

iCodeSometime opened this issue Nov 26, 2022 · 1 comment
Labels
breaking-change

Comments

@iCodeSometime
Copy link
Owner

iCodeSometime commented Nov 26, 2022 •
edited
Loading

Currently Piece::to_string accepts a color argument and is capital for white and lowercase for black.
@iCodeSometime
Copy link
Owner Author

Rename existing implementation Piece::to_fen

@iCodeSometime iCodeSometime mentioned this issue Nov 29, 2022
Open
7 tasks
@iCodeSometime iCodeSometime changed the title Piece::to_string should not accept an argument, and should always be uppercase Replace to_string and from_string with more descriptive terms - e.g. to_fen Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iCodeSometime